Skip to content
This repository has been archived by the owner on Jul 12, 2021. It is now read-only.

Read Only Mode - Issue #81 #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pelonchasva
Copy link

These changes implement the read only feature for the editor, it disables the editor and hides the editor toolbar to avoid updating the content of the editor.

…bles the editor and hides the editor toolbar
type Props = StateProps & DispatchProps;

/**
* Preference fieldset for setting the editor state
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably will want to update this default comment

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok if I put it like this: Preference fieldset for setting the editor in read only mode?

@Owen-Krueger
Copy link
Contributor

Owen-Krueger commented Oct 4, 2020

You should be able to run yarn format:fix to clean up the code and allow it to pass the lint check on this pull request

@pelonchasva
Copy link
Author

You should be able to run yarn format:fix to clean up the code and allow it to pass the lint check on this pull request

Thank you, I was able to run it and seems to work fine, should I create a new PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants